Conversation
The chart accepted any Kubernetes resource settings but rendered only CPU and memory, silently dropping ephemeral-storage requests and limits. Pods could therefore land on nodes without enough allocatable ephemeral storage, even when the aggregator emptyDir had a sizeLimit. Resource blocks now pass through every key they are given. The aggregator collector, which writes the metric files to the shared emptyDir, also requests aggregator.database.emptyDir.sizeLimit as ephemeral storage when it is set, unless the collector requests ephemeral storage explicitly. No limit is derived, and default renders are unchanged because sizeLimit defaults to empty. Helm unit tests cover pass-through, the derived request, the explicit override, and the unset and disabled cases; existing template baselines are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chart accepted any Kubernetes resource settings but rendered only CPU and memory, silently dropping
ephemeral-storagerequests and limits. Pods could land on nodes without enough allocatable ephemeral storage, even when the aggregator emptyDir had asizeLimit.generateResourcesnow passes through every non-empty key underrequestsandlimits.aggregator.database.emptyDir.sizeLimitas ephemeral storage when it is set, unless the collector requests ephemeral storage explicitly. No limit is derived.sizeLimitdefaults to empty, and notests/helm/template/baselines changed.Testing
make helm-test-unittest helm-test-schema helm-lint: 684/684 unit tests pass; schema tests and lint pass.🤖 Generated with Claude Code