Repository navigation
Headless device login, hardened install/update, and npm packages #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
edumansky
wants to merge
6
commits into
main
Choose a base branch
from
headless-install
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
38fc965
Add headless device login and harden install and update
edumansky f0eb8d3
Publish the CLI to npm as per-platform binary packages
edumansky e572293
Start the MCP server without a login and prefer npm trusted publishing
edumansky bdd941c
Keep read-only token purging correct with the file token store
edumansky 0c202e2
Tidy the headless login and read-only mode integration
edumansky b3be81f
Address Codex review of the token store and device login
edumansky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "io" | ||
| "os" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/Cloverhound/webex-cli/internal/auth" | ||
| ) | ||
|
|
||
| func captureStdout(t *testing.T, fn func()) string { | ||
| t.Helper() | ||
| r, w, err := os.Pipe() | ||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| old := os.Stdout | ||
| os.Stdout = w | ||
| fn() | ||
| os.Stdout = old | ||
| w.Close() | ||
| out, _ := io.ReadAll(r) | ||
| return string(out) | ||
| } | ||
|
|
||
| func TestAuthStatusReportsEnvTokenWithoutStoredLogin(t *testing.T) { | ||
| home := t.TempDir() | ||
| t.Setenv("HOME", home) | ||
| t.Setenv("USERPROFILE", home) | ||
| t.Setenv(readOnlyEnv, "") | ||
| t.Setenv("WEBEX_TOKEN", "") | ||
| t.Setenv(auth.RefreshTokenEnv, "rt") | ||
|
|
||
| out := captureStdout(t, func() { | ||
| if err := authStatusCmd.RunE(authStatusCmd, nil); err != nil { | ||
| t.Error(err) | ||
| } | ||
| }) | ||
| if !strings.Contains(out, "$"+auth.RefreshTokenEnv+" is set") { | ||
| t.Errorf("status output does not mention the env token:\n%s", out) | ||
| } | ||
| if strings.Contains(out, "No authenticated user") { | ||
| t.Errorf("status claims no user although commands authenticate from the env:\n%s", out) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3] Report environment authentication before checking the default user
The new environment-status reporting is unreachable when
cfg.DefaultUseris empty. That is the normal fresh-container case forWEBEX_REFRESH_TOKEN, soauth statusreports “No authenticated user” even though API commands authenticate successfully. Inspect environment sources before the stored-user early return, and distinguish an available environment credential from a verified token without unnecessarily refreshing it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valid; fixed in b3be81f.
auth statusnow reports$WEBEX_TOKEN/$WEBEX_REFRESH_TOKENbefore checking for a stored default user. With no stored user it says commands authenticate with the env value, and it no longer prints "No authenticated user" in that case. It does not refresh the token just to show status. Regression test:TestAuthStatusReportsEnvTokenWithoutStoredLogin.