Skip to content

[PR #837] Config templates still say Coinbase One tiers give fee-free buys #838

Description

@eaitbrahim

Found during review of PR #837 at packages/keel-core/keel_core/config.py:71.

Problem: PR #837 (closes #836) corrects the operator-facing text that called rail 14's cap a fee-free allowance. The shipped config templates were not corrected and still make that claim. keel/templates/config.live.yaml is what keel setup writes into a live deployment (keel/commands/setup.py:966). In it, line 124 says "fee-free monthly TRADING VOLUME", line 128 says "Premium -- always fee-free", and line 140 says "Coinbase Advanced trading fees applied to volume beyond a tier's free allowance". The same wording is also in keel/templates/config.yaml, config.yaml, config.paperforward.yaml, config.paper-hourly.yaml (lines 87, 147 and 153), and in the TierConfig docstring in packages/keel-core/keel_core/config.py (lines 212-217).

Failure: Run keel setup in live mode on the PR #837 head (3d71730). The generated config.yaml tells the operator that buys inside the tier's volume are fee-free. Keel's Advanced Trade orders pay the maker/taker schedule on every order (Intro tier, 0.9% taker, has_promo_fee: false on 2026-09-27). This is the misstatement #836 was opened to remove.

Severity: warning

Review thread: #837 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingrailsUn-overridable safety rail / guard (Compliance & rails)

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions