Skip to content

London | 26-ITP-Sept | Fung Nin Lee | Sprint 1 | Forms Control #1484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leerogerfn wants to merge 9 commits into
base: main
Choose a base branch
from
+46 −13
Open

London | 26-ITP-Sept | Fung Nin Lee | Sprint 1 | Forms Control #1484

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3acf9bd
initial setup
leerogerfn Sep 8, 2026
4ea47cd
submit form requirements.
leerogerfn Sep 8, 2026
b23155b
added fieldset for the form
leerogerfn Sep 9, 2026
56ce344
added customer name
leerogerfn Sep 9, 2026
8eebedc
added emal address
leerogerfn Sep 9, 2026
f81e814
added color with 3 options
leerogerfn Sep 9, 2026
00d9593
added size for 6 options
leerogerfn Sep 9, 2026
b71b7df
added submit button
leerogerfn Sep 9, 2026
7a2fe70
final version
leerogerfn Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 46 additions & 13 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,53 @@
<meta name="viewport" content="width=device-width, initial-scale=1" />
</head>
<body>
<header>
<h1>Product Pick</h1>
<fieldset>

@hey-hammad hey-hammad Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the fieldset tags, think about the correct placement when building a form, more on this in the link below. Thanks

https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/fieldset

<legend>Product Pick</legend>
</header>

@hey-hammad hey-hammad Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please review the header tag, there is no opening <header> tag.

<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
</footer>
</body>
<label for="name">Customer Name</label>
<input type="text" id="name" name="name" pattern=".*\S.*\S.*">
<div>
<label for="email">Email</label>
<input type="email" id="email" name="email">

@hey-hammad hey-hammad Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The task says all fields are required. How will the form prevent submission if the user leaves the name, email, colour, or size blank?

</div>
<p></p>

@hey-hammad hey-hammad Sep 11, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason for adding empty <p> tag here?

<div>
Color
<div>
<label for="red">Red</label>
<input type="radio" id="red" name="color" value="red">
</div>
<div>
<label for="blue">Blue</label>
<input type="radio" id="blue" name="color" value="blue">
</div>
<div>
<label for="green">Green</label>
<input type="radio" id="green" name="color" value="green">
</div>

<div>
<label for="size">Size</label>
<select name="size" id="size">
<option value="xs">XS</option>
<option value="s">S</option>
<option value="m">M</option>
<option value="l">L</option>
<option value="xl">XL</option>
<option value="xxl">XXL</option>
</select>
</div>
</form>
</main>
</fieldset>

<button type="submit">submit</button>

@hey-hammad hey-hammad Sep 11, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submit button currently doesn't do anything, will moving to another place fix this?


<footer>
<p>By Fung Nin Lee (Roger) HOMEWORK SOLUTION</p>
</footer>

</body>
</html>
Loading