London | 26-ITP-SEP | Russom Gebremeskel | Sprint 3 | Dead Code by russom-g · Pull Request #1632 · CodeYourFuture/Module-Structuring-and-Testing-Data

russom-g · 2026-09-30T21:53:35Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1066

Changelist

Unused code remove. Function refactored to continue to work for any input it's given.

abdishakoor-dev

You found all the real dead code: greetingStr and the line after return in exercise 1, and capitalisedPets and logPets in exercise 2. The trouble is that more than the dead code has gone, so neither file prints what it did before.

Before I can mark this Complete:

exercise-1.js now prints nothing. The starter printed hello, Aman!, and that final log is what the dead code was being removed around. See my comment on line 6.
exercise-2.js should still print { HAMSTER: 3, HORSE: 1 } from the pets array, and countAndCapitalisePets should still count whatever array it is given. See my comments on lines 4, 10 and 25.
PR tidy-up: add CYF-1066 under a "Task code" heading in the description, update the title to London | 26-ITP-Sep | Russom Gebremeskel | Sprint 3 | Dead Code (you're in the September cohort now, and this task is Sprint 3), and remove the NotCoursework label. That label tells volunteers the PR isn't coursework and to skip it; the bot's message was asking for the task code, not that label.

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-10-05T10:55:09Z

-  const greetingStr = greeting + ", " + name + "!";
  return `${greeting}, ${name}!`;
-  console.log(greetingStr);
 }


Run node dead-code/exercise-1.js on main and on your branch. What does each print? Dead code is code that never affects the output, so was console.log(greetingMessage) dead?

I made the sayHello function to continue to work for any reasonable input it's given.

I added a console.log() now

The log is back, thanks. Run node dead-code/exercise-1.js now: it prints Hi, Aman!, but main prints hello, Aman!. Where does the Hi on line 8 come from, and what did the starter pass in as the greeting?

I fixed the problem

abdishakoor-dev · 2026-10-05T10:55:09Z

@@ -2,27 +2,24 @@
 // The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

 const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];


Where is pets used now?

I misunderstood the instruction. It is fixed now.

Fixed, pets is used again and unchanged.

abdishakoor-dev · 2026-10-05T10:55:09Z

-    }
-  });
+  petsArr
+    .filter((pet) => pet[0] === "h")


The comment on line 2 says this function should keep working for any reasonable input. What does countAndCapitalisePets(["dog", "cat", "dog"]) return on main, and what does it return now?

Try it: countAndCapitalisePets(["dog", "cat", "dog"]) returns {} with your version. On main it returns { DOG: 2, CAT: 1 }.

The .filter((pet) => pet[0] === "h") on line 10 is the reason. In the starter, the filtering happened outside the function, on its own line: const petsStartingWithH = pets.filter(...). That line wasn't dead code, because its result was what got passed into the function.

Put that line back under pets, take the filter out of the function so it goes back to a plain petsArr.forEach(...), and pass petsStartingWithH into the function on the last line. Your counting code on lines 12 to 18 doesn't need to change.

abdishakoor-dev · 2026-10-05T10:55:09Z

-
-console.log(countedPetsStartingWithH); // { 'HAMSTER': 3, 'HORSE': 1 } <- Final console log
+const animals = ["lion", "hyena", "elephant", "hippo", "tiger", "hippo"];
+console.log(countAndCapitalisePets(animals));


The starter's final log printed { HAMSTER: 3, HORSE: 1 }. What does yours print, and which array is it counting?

The output is right again. Once the filter moves back out of the function (see line 10), make sure it still prints { HAMSTER: 3, HORSE: 1 }.

Done.

Thanks for the feedback @abdishakoor-dev

abdishakoor-dev

Thanks for replying to each comment. The PR tidy-up is done too: title, task code and label are all sorted, and exercise 2 prints { HAMSTER: 3, HORSE: 1 } again.

Three things left before I can mark this Complete:

exercise-2.js: countAndCapitalisePets only counts pets that start with "h". The filter is now inside the function (line 10), so any other array gives the wrong answer. My reply on line 10 explains how to move it back out.
exercise-1.js prints Hi, Aman!. The starter printed hello, Aman!, and removing dead code shouldn't change the output. See my reply on line 6.
Prettier on exercise-1.js. The file is missing the empty line at the end. Right click in the editor, choose Format Document, and save. To make this happen every time you save, follow the format on save steps here: https://github.com/CodeYourFuture/Module-JavaScript-Fundamentals/blob/main/practical_guide.md

Run node dead-code/exercise-1.js and node dead-code/exercise-2.js before you push and check they print exactly what main prints. Add the Needs Review label again once you've pushed.

russom added 22 commits September 28, 2026 14:46

List edge cases for test.

301ea63

Update list.

2501561

Add an if condition to check midnight

63e477b

Add another case to test midnight

a8e1b2d

Add test case 00:01 to 12:01 am

9e2cef8

Add condition for checking midday 12 pm

2ba2e34

Add test case for 01:00 to 01:00 am

06d5f91

Add test case for 11:59 to 11:59 am

3dc6da6

Add test case for 12:01 to 12:01 pm

1e6cb55

Add test case for 13:00 to 1:00 pm

61b2ce7

Add test case fo 23:59 to 11:59 pm

0407869

Add padStart method to hours

06d3f9a

Add more description.

598f744

Add padStart method to convert 23:00 to 01:00pm

e6fde3b

Edit comments

c2f743c

Inline code directly into return statement

e7ff9c7

Change am and pm to lower case and update description.

751fb78

Unreachable code.

4707f5a

Remove unreachable and redundant code.

f504687

Remove unused code

d9197c4

Update function to work for any input.

9494c3d

Format code with prettier.

582699c

This comment has been minimized.

Sign in to view

russom added 2 commits October 3, 2026 15:13

Stop tracking files

b806b41

Stop tracking files

fcf27e7

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2026

russom-g added the NotCoursework label Oct 3, 2026

Restore files unrelated to this PR

04f544f

russom-g added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 5, 2026

abdishakoor-dev reviewed Oct 5, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 5, 2026

russom-g added 3 commits October 22, 2026 15:40

Add console.log()

3931817

Remove redundant const pets variable.

f9cb199

Refactor code.

f920355

russom-g added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. NotCoursework labels Oct 22, 2026

abdishakoor-dev reviewed Oct 29, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2026

russom-g added 2 commits October 29, 2026 23:42

Fix code to print 'hello Aman'

05a9485

Update code to work for any input given.

a3ec00c

russom-g added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 30, 2026

		@@ -2,27 +2,24 @@
		// The countAndCapitalisePets function should continue to work for any reasonable input it's given, and you shouldn't modify the pets variable.

		const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"];

Conversation

russom-g commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Task code

Changelist

Uh oh!

This comment has been minimized.

This comment has been minimized.

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

russom-g Oct 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

russom-g commented Sep 30, 2026 •

edited

Loading

russom-g Oct 22, 2026 •

edited

Loading