Skip to content

London | 26-ITP-Sep | Chandramani Gaire | Sprint 3 | Refactoring Dead Code - #1763

Open
gaireprakash20-ops wants to merge 6 commits into
CodeYourFuture:mainfrom
gaireprakash20-ops:dead-code
Open

gaireprakash20-ops wants to merge 6 commits into
CodeYourFuture:mainfrom
gaireprakash20-ops:dead-code

Conversation

@gaireprakash20-ops

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1066

Changelist

I removed the unnecessary code from this exercise.

@gaireprakash20-ops gaireprakash20-ops added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 27, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The objective of this exercise is only to delete unused/dead code (and not commenting out unused code or refactoring the code).

Could you restore the original code and delete only the dead code?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2026
@gaireprakash20-ops

Copy link
Copy Markdown
Author

I deleted all unused code from both exercises.

@gaireprakash20-ops gaireprakash20-ops added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 29, 2026
Comment thread dead-code/exercise-1.js

@cjyuan cjyuan Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still dead code in this file.

Note: Dead code (unused identifier) usually appears in different color in VS Code editor.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants