London | ITP-May-26 | Dagim Daniel | Sprint 3 | Project TV Show - #94
London | ITP-May-26 | Dagim Daniel | Sprint 3 | Project TV Show#94Dagim-Daniel wants to merge 6 commits into
Conversation
Dagim-Daniel
added
Needs Review
LonMcGregor
added
the
Review in progress
LonMcGregor
left a comment
LonMcGregor
left a comment
There was a problem hiding this comment.
Good use of semantic HTML and templates. The functionality is all present. Your code is well organised. Good use of caching. Good work completing this by yourself.
I have spotted a few minor things though, and some extra questions. if you want an extra challenge now the ITP is over, you can try to address them.
| </div> | ||
| <div id="error-message" class="status-message error-state" hidden></div> | ||
|
|
||
| <div id="shows-root" aria-label="TV Shows Listing"></div> |
There was a problem hiding this comment.
Is this the right way to use an aria-label? This value typically also requires an appropriate "role" to be set for it to be meaningful
| <footer id="bottomBar"> | ||
| <span>Original Link: </span> | ||
| <a id="original-link" href="https://tvmaze.com/" target="_self" | ||
| >TVMaze.com</a |
There was a problem hiding this comment.
Did you mean to break this over multiple lines? It isn't wrong, but it makes the code look a little difficult to read.
| imgElem.alt = show.name || "Show poster"; | ||
| imgElem.addEventListener("click", () => loadEpisodesForShow(show.id)); | ||
|
|
||
| cardNode.querySelector(".show-summary").innerHTML = show.summary || ""; |
There was a problem hiding this comment.
Do you think there are any potential side effects of setting the HTML this way?
|
|
||
| const imgElem = cardNode.querySelector(".show-image"); | ||
| imgElem.src = show.image?.medium || ""; | ||
| imgElem.alt = show.name || "Show poster"; |
There was a problem hiding this comment.
Is this the best way to use this alt tag? See what https://axesslab.com/alt-texts/ has to say
LonMcGregor
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
all Levels of TV project Has been done
NOTE: since i have NO partner to work with and been advised to work alone, i did this project solo.
Netlify link : https://tv-show-dagim-daniel.netlify.app/