Repository navigation
Better submit block relay error logging - #502
Merged
Merged
Conversation
JasonVranek
force-pushed
the
fix/v2-submit-block-relay-error
branch
from
September 28, 2026 17:49
10795d8 to
9040c18
Compare
ltitanb
approved these changes
Sep 29, 2026
ManuelBilbao
approved these changes
Sep 29, 2026
JasonVranek
force-pushed
the
fix/v2-submit-block-relay-error
branch
from
September 29, 2026 20:09
9040c18 to
600889c
Compare
JasonVranek
added a commit
that referenced
this pull request
Oct 2, 2026
…secrets, rustls bump Brings in #502 (submit-block relay error logging), the v0.11.0-rc2/rc3 releases with the rustls advisory bump, relay headers read from a secret file or env var (#498), and the ws stream metrics endpoint (#499). Conflict resolutions: - relay.rs: kept epbs's relay_headers() helper, shared by the HTTP client and the stream handshake, and moved main's header resolution into it (HeaderSource literal/file/env, sensitive values, the secret-source log line). Its error messages now format the key, which epbs's did not. - config/pbs.rs: one test module holding epbs's unknown-[pbs]-field tests and main's header-source tests. - config/utils.rs: main's RELAY_URL test constant in test_env. - Cargo.lock: main's lockfile, plus only what epbs adds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v2 branch added in #468 added a logging regression that dropped the relay's reason in the body. Now when a relay refuses a
submit_blinded_block, log the relay's explanation instead of just a status code.Note passing CI required bumping the rustls version