Repository navigation
Check toolbox-assets downloads against the manifest checksums - #9
Merged
Merged
Conversation
fetchToolboxAsset downloads to a .part file, checks it against the SHA-256 that the toolbox-assets manifest (manifest-v3) lists for its URL, and deletes it with an error when it differs. An asset the manifest does not list, or a manifest that cannot be read, gives a warning. The issue link points to CompMetEng/RAVEN.
Contributor
Function test results418 tests 379 ✅ 1m 17s ⏱️ Results for commit 79d7447. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchToolboxAssetchecks every download against the SHA-256 checksum that the toolbox-assets manifest (releasemanifest-v3) lists for its URL:<name>.part, checked, and only then moved to its name, so an interrupted or corrupted download never looks like a finished one.RAVEN:fetchToolboxAsset:checksum.RAVEN:fetchToolboxAsset:unverified,RAVEN:fetchToolboxAsset:manifest) and keeps the file.tInstallation/fetchToolboxAssetChecksDownloadsdownloads a small published asset and checks that it is kept and reused. The BLAST+, DIAMOND and HMMER downloads oftBinaries, and GECKO's BRENDA files (CompMetEng/GECKO#11), pass the check.