Repository navigation
Preserve own prototype-like keys during canonicalization - #5
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canonicalizing a JSON object with an own
__proto__key previously invoked the inherited prototype setter and could omit the key from serialized output. Define own enumerable, writable and configurable data properties instead, preserving the ordinary object prototype, deterministic key sorting, array order, undefined omission and nonmutation.Adds four dependency-free Node 24 regression tests and documents the canonical-string/hash migration for affected inputs. CI retains Node 20 typecheck, Vitest and build checks, caps Vitest workers at two with file parallelism disabled, checks the installed option support, and adds a separate serial Node 24 regression job. Jobs use GitHub-hosted Ubuntu with 15/5-minute timeouts. Dependencies and lockfile are unchanged.
Validation: four regression tests pass locally; the same tests against the original source give three expected failures and one pass. Full Vitest, typecheck and build await this PR's hosted CI. No release or runtime support-floor change.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.