Skip to content

fix(bolt): compile hot splits once without reverting main - #2493

Draft
seonghobae wants to merge 3 commits into
mainfrom
seonghobae/bolt-2205-regex-current
Draft

seonghobae wants to merge 3 commits into
mainfrom
seonghobae/bolt-2205-regex-current

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

Tests

  • test_requirement_splits_are_compiled_once_and_keep_pin_behavior locks the compiled hash delimiter and package-name pattern, including a mixed-whitespace hash line.
  • test_runtime_boundaries_are_compiled_once_and_slugs_stay_stable locks native tool slugs, case-insensitive clause splits, and sentence splits.
  • Related materializer, uv-export, and runtime-claim tests passed locally (177 passed). The two touched modules' changed lines are covered; a subset run still leaves pre-existing uncovered lines in materialize_base_python_requirements.py that this diff does not touch.

Developer experience

Reviewers can see the intended regex change without a 12k-line control-plane deletion in the same pull request.

User experience

Hash-pin detection, VCS import names, and browser-receipt tool slugs stay the same. The hot paths no longer recompile those patterns on each call.

seonghobae and others added 3 commits September 28, 2026 21:13
Rebuild #2205 on current main with only the intended module-level
re.compile / native split-join changes; the post-merge tip had deleted
queue-health and coalesce control-plane files.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep hash-pin detection, package import names, and receipt slug
boundaries while the hot patterns compile once.
The compiled clause boundary must still ignore case, matching the
previous inline re.split flag.
@coderabbitai

coderabbitai Bot commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 17 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 9626ba5a-289e-458f-923f-14416c339de7

📥 Commits

Reviewing files that changed from the base of the PR and between 3295c25 and 1505df5.

📒 Files selected for processing (5)
  • .jules/bolt.md
  • scripts/ci/materialize_base_python_requirements.py
  • scripts/ci/opencode_review_normalize_output.py
  • tests/test_materialize_base_python_requirements.py
  • tests/test_opencode_review_normalize_output.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact-head admission correction — 1505df5dad73d86cb438be74d75ace2043e12cc3

Ready is review admission only. Fresh audit against base 3295c259bcb688673170a1902f46d1d6c775bad4 found:

  • latest terminal workflow blockers: SAST Semgrep 36422000731=failure, Trusted uv Materializer Quality CI 36422000733=failure, Security Scan 36422000767=failure, Python Security 36422000677=failure, CodeQL PR 36422000811=failure

This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed.

@seonghobae
seonghobae marked this pull request as draft September 30, 2026 05:22

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant