[mostafasadeghidev]

Three reports from one install, all the same shape: an affordance that reads as if it already honours the selection, and does not.

Right-click ignored the selection

openContextMenu stored only the clicked asset, and the delete handler acted on contextMenu.asset alone. Right-clicking one of five selected files and choosing Delete trashed exactly one and left four selected — no error, nothing to notice.

The fix is the rule the same component already used in handleAssetDragStart: an item inside the selection acts on the whole selection, an item outside acts on itself. It now lives in utils/actionTargets.ts, and both the drag and the menu call it, so they can't drift apart. The menu now shows a "5 files" header and a "Trash 5 files" label so the scope is visible before the click, and hides Rename for a multi-selection because there is one name field.

Deliberately not adopting the clicked asset into the selection the way SiteExplorerPanel does. Media derives its floating windows from the selection during render — viewer at <= 1, bulk edit at >= 2 (MediaPage.tsx) — so writing the selection from a menu opener would pop a window open underneath the menu.

The trash had no bulk delete

A selection there offered Restore and nothing else, leaving "empty the trash" a one-file-at-a-time job through the preview window.

runPurgeAll sits beside its Trash and Restore siblings and loops the same single-id endpoint they do, so no server work is needed. It confirms first, and both the count and the purge cover only the trashed members: purgeAsset 400s on a live asset.

A permanent delete from the menu asks first

In the trash view the menu acts on the whole selection too, so it could purge N files in one click. It now always confirms, through the admin's ConfirmDeleteProvider with alwaysConfirm — the confirmBeforeDelete preference defaults off and governs reversible trashing, not this. A single file asks as well, worded as #497 words it, so whichever of the two lands second resolves to the same code.

Escape did not close the windows

Every other overlay in the admin takes it. These windows overlay the grid they were opened from, and the only way out was the header's close button.

useTopmostEscape carries the settings modal's rule — only the topmost layer reacts, so a confirmation opened from inside a window owns Escape until it closes rather than collapsing the stack in one press. FloatingWindow uses it, which covers bulk edit, the upload queue and the agent image preview; the media viewer renders its own shell, so it wires the hook directly.

Tests

multiSelectActions.test.tsx renders MediaCanvas and BulkEditWindow inside the real session and confirm providers and drives the menu, the drag and the dialog — no copies of the logic. Each case was checked against a deliberately broken component: no confirmation, a menu or drag that ignores the selection, a bulk purge over the whole selection. Every one turns the suite red.

Writing them found a bug the copies hid: the bulk dialog counted only trashed files, but the purge loop ran over the whole selection, firing a request per live file that was bound to 400. Fixed in the same commit.

bun test src/__tests__/media/   41 pass, 0 fail
tsc -b, eslint                  clean

Co-Authored-By: Claude Opus 5 noreply@anthropic.com

[mostafasadeghidev]

I've updated this one based on your comments in #501.

Deleting from the trash through the context menu now always asks for confirmation, both for a single file and for a selection. I used the same wording as #497 for the single-file case, so the two should fit together fine whichever one goes in first.

The tests now render MediaCanvas and BulkEditWindow and go through the menu, the drag and the confirm dialog, instead of checking local copies of the logic. I also broke the components on purpose to make sure the tests actually fail when they should.

While doing that I found a real bug: the bulk delete dialog only counted the trashed files, but the purge was sent for every file in the selection, including ones that weren't trashed. It now only deletes what the dialog shows.