feat(submissions): index page style adjustments - #8606
Merged
Merged
Conversation
adi-herwana-nus
commented
Sep 27, 2026
adi-herwana-nus
commented
Contributor
- replace ConfirmationDialog calls with Prompt
- improve formatting of action buttons
- tweak mass-publish confirmation string
- replace ConfirmationDialog calls with Prompt - improve formatting of action buttons - tweak mass-publish confirmation string
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The remaining test-coverage findings are non-blocking nits.
Review effort: Lite
Findings: None
What changed in this PR
Updates the submissions index styling, confirmation prompts, action-button formatting, and localized confirmation text.
Changes:
- Replaces legacy confirmation dialogs with
Prompt. - Improves action-button spacing and formatting.
- Updates English, Chinese, and Korean translations.
- Adjusts feature-spec confirmation helpers.
| File | Summary |
|---|---|
spec/features/course/assessment/submission/submissions_spec.rb |
Updates confirmation acceptance helpers. |
client/locales/zh.json |
Updates Chinese confirmation text. |
client/locales/ko.json |
Updates Korean confirmation text. |
client/locales/en.json |
Updates English confirmation text. |
client/app/bundles/course/assessment/submission/translations.ts |
Updates default confirmation wording. |
client/app/bundles/course/assessment/submission/pages/SubmissionsIndex/index.tsx |
Migrates confirmations and adjusts button layout. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.