Repository navigation
fix(frontend): stop settings pages scrolling the last section off screen - #19
Merged
Merged
Conversation
Replace the near-viewport-tall bottom padding on the settings content column with a measured spacer that gives the last section exactly enough tail to reach the scroll-spy reading line, and no more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On every settings page (user, site, org) you could scroll so far past the end that the last section, usually Danger zone, ended up almost off the top of the screen, above a screenful of blank space.
The content column had a fixed bottom padding of nearly a full viewport, so short trailing sections could still reach the scroll-spy reading line. That padding is now a measured spacer: it gives the last section exactly enough tail to reach the reading line (about 160px from the top) and no more. It re-measures on resize and as content loads, and adds nothing when the page fits without scrolling. Scroll-spy behaviour is unchanged, so Danger zone still highlights at the bottom without stealing the highlight from Sessions. Unit tests cover the spacer sizing.