Repository navigation
feat(tray): record a region, and stop the recording, from the tray menu - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recording a region needed the record hotkey or the main window. The tray menu now has a Record region item under Capture region. While a recording runs, the item reads Stop recording and stops it. It goes through the same toggle as the record hotkey, so it also stops a recording that
snapr --recordstarted. On Windows the item is the bold default when left-clicking the icon is set to record.Proof: on a Windows release build, Record region → drag a region → the menu read Stop recording → Stop wrote the mp4 → the menu read Record region again. With
tray_click = "record"the item is bold. Clippy is clean, 188 tests pass, and Linux passescargo checkin WSL. macOS wasn't compiled here (no Apple SDK); its item mirrors the Capture item.Reviewed with sol-loop: 1 round with gpt-6.1-sol. Sol verdict: approved
Created with Claude Opus 5.5 in Claude Code.