Repository navigation
feat(toast): copy and dismiss the toast by touch, with a tap or a swipe - #16
Open
CubityFirst wants to merge 1 commit into
Open
CubityFirst wants to merge 1 commit into
CubityFirst wants to merge 1 commit into
Conversation
A finger only acts as the left button, so it could open the toast but not copy or close it, and a finger that moved started a drag-out that only works with the mouse, losing the tap. A tap now shows Open, Copy and Close buttons for a second tap to pick, and swiping the toast left or right dismisses it; a short swipe puts it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a touchscreen, a tap on the toast opened it, but there was no way to copy the capture or dismiss the toast: those are on the middle and right mouse buttons, and a finger only acts as the left one. A finger that moved even slightly also started the drag-out, which only works with a held mouse button, so the tap was lost.
Now:
Not yet tested on a real touchscreen. The button layout was checked with the
toast_previewrender test, which now includes the button variants.