Skip to content

Fix attuned recipes clicks and drags on 26.3 - #244

Merged
rubensworks merged 1 commit into
master-26from
fix-mouse-buttons-26.3
Sep 25, 2026
Merged

rubensworks merged 1 commit into
master-26from
fix-mouse-buttons-26.3

Conversation

@rubensworks

@rubensworks rubensworks commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Related to CyclopsMC/IntegratedDynamics#1750 (same root cause as CyclopsMC/IntegratedTerminals#230).

Cause

Minecraft 26.3 moved input to SDL, so MouseButtonEvent.button() now uses left 1, middle 2, right 3 (InputConstants.MOUSE_BUTTON_*). Before, it used GLFW's left 0, right 1, middle 2. ContainerScreenPartInterfaceCraftingAttunedRecipes checked button() == 0 in mouseClicked, mouseDragged and mouseReleased, so left-clicking or dragging over recipes to enable or disable them did nothing.

Fix

Compare against InputConstants.MOUSE_BUTTON_LEFT.

Validation

  • ./gradlew build passes, and ./gradlew runGameTestServer passes all 82 required tests.
  • Checked in a NeoForge 26.3 dev client: an attuned crafting interface on a crafting table (1341 recipes).
    • This branch: clicking the first recipe disabled it (0 to 1 disabled), and dragging across the second row disabled 9 more (10). Closing and reopening the GUI still showed 10, so the server kept the change.
    • Original master-26 screen, hotswapped into the same client: a click and a row drag on other recipes changed nothing (stayed at 10).
    • Fix swapped back in: the same click and drag worked (11, then 20).

🤖 Generated with Claude Code

https://claude.ai/code/session_016VFfUPDxbJ8RqPeQHsAbh7

Minecraft 26.3 uses SDL mouse button ids (left 1, middle 2, right 3)
instead of GLFW's (left 0, right 1, middle 2). The attuned recipes
screen only reacted to button 0, so clicking or dragging over recipes
to toggle them did nothing.

Related to CyclopsMC/IntegratedDynamics#1750

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016VFfUPDxbJ8RqPeQHsAbh7
@rubensworks
rubensworks merged commit c031052 into master-26 Sep 25, 2026
7 checks passed
@rubensworks
rubensworks deleted the fix-mouse-buttons-26.3 branch September 25, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants