Repository navigation
Make Menril wood variants burn into charcoal - #1748
Merged
Merged
Conversation
Add all Menril logs and wood to the vanilla logs_that_burn tags, matching vanilla wood blocks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qshy4VBPjpdWRG1wD7EoAk
|
coverage: 16.124%. remained the same — claude/menril-logs-that-burn-1.20 into master-1.20-lts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both vanilla
logs_that_burntags now reference#integrateddynamics:menril_logsinstead of listing individual blocks. This addsmenril_woodandmenril_wood_stripped, which vanilla also does for its own wood blocks (for exampleoak_woodvia#oak_logs). As a result they smelt into charcoal and are treated like the other burnable logs.Validation:
./gradlew buildpasses. This branch has no game test setup. The 1.21-lts PR adds game tests for all five variants.Upmerge note: on 1.21-lts and later the item tag lost the
menril_log_strippedentry, and the companion 1.21-lts PR sets both files to the same content as this PR. So the two should upmerge cleanly or with a trivial conflict.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qshy4VBPjpdWRG1wD7EoAk
Generated by Claude Code