Repository navigation
Fix stripped Menril log and wood not smelting into charcoal - #1749
Merged
Merged
Conversation
The stripped Menril log entry in the item logs_that_burn tag was lost when upmerging to MC 1.21, and Menril wood variants were never included. Both vanilla logs_that_burn tags now reference #integrateddynamics:menril_logs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qshy4VBPjpdWRG1wD7EoAk
|
coverage: 48.062% (+0.03%) from 48.037% — claude/menril-logs-that-burn-1.21 into master-1.21-lts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1685 added
menril_log_strippedto bothlogs_that_burntags on 1.20-lts. The upmerge to 1.21, wheretags/itemswas renamed totags/item, dropped it from the item tag only. So on 1.21-lts and later the stripped Menril log doesn't smelt into charcoal. Menril wood and stripped wood were never in either tag.Changes:
logs_that_burntags now reference#integrateddynamics:menril_logs. This matches the 1.20-lts companion PR, so upmerging keeps the files identical.GameTestsMenrilLogs: each of the five Menril log/wood variants is put in a real furnace and must produce charcoal.Validation:
./gradlew build runGameTestServer: all 1002 required tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01Qshy4VBPjpdWRG1wD7EoAk
Generated by Claude Code