Repository navigation
Add focus mode and script renaming to the scripting terminal - #82
Closed
rubensworks wants to merge 17 commits into
Closed
rubensworks wants to merge 17 commits into
rubensworks wants to merge 17 commits into
Conversation
Paths in the script list are truncated, so files with a common prefix, such as inventory_sorting_main.js and inventory_sorting_test.js, or files in subdirectories could not be told apart. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
When the file watcher reloaded a disk directory, for example because the server just wrote or deleted a script there, it replaced all scripts in memory with the disk contents. Changes that were not flushed to disk yet were lost, such as the new file of a rename when the old one was deleted first. Keep unflushed changes when reloading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
New scripts were always named script0.js, script1.js and so on, and could only be renamed or moved into directories through the file system, which players on a server can't access. Right-click a script to rename it, which also allows moving it into a directory or changing its language through its extension. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
…x/6-layout-and-files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
The editor only uses a small part of the screen, showing about a dozen wrapped lines. Add a button to show only the editor, using most of the screen. Escape or the button returns to the normal terminal. See #44 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
This was referenced Oct 17, 2026
Coverage Report for CI Build 39132296337Coverage decreased (-1.9%) to 41.789%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions343 previously-covered lines in 5 files lost coverage. Coverage Stats
💛 - Coveralls |
…x/6-layout-and-files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
…x/6-layout-and-files The file watcher reloads now only apply changes made outside of the mod, which also covers unflushed changes, so the separate handling of dirty paths during reloads is dropped. Its test still passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
…x/6-layout-and-files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
…x/6-layout-and-files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
…x/6-layout-and-files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
…x/6-layout-and-files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
The focus mode button overlapped the new toolbar. Show it as the last toolbar button with its own icons, keep the toolbar available in focus mode, and list renaming and focus mode in the shortcut overview. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
…x/6-layout-and-files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
With the focus mode button in the toolbar, the margin before the toolbar cut off the last letters of the English title, while it fits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
…x/6-layout-and-files
These were listed in the removed shortcuts button, so they now go in the info book section with the other shortcuts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
…x/6-layout-and-files
Member
Author
|
Replaced by #89: same changes, rebased with every commit as one standalone change. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6, the last of the scripting terminal UX stack. Stacked on #81 (then #80, #79, #78, #77).
I checked each problem in a dev client driven by clientdevbridge before fixing it, then checked it again with this branch.
inventory_sorting_main.jsandinventory_sorting_test.jsboth showed asinventory_sorting..., andlib/helpers/math_utils.jswas cut off.scriptN.js, and could only be renamed or moved through the file system, which players on a server can't reach.util/a/new.jsmoves it into folders, and changing the extension changes its language. The open script stays open with its undo history. Checked in-game: renames into new folders keep content on disk; renaming onto an existing name is refused;../escape.jsis rejected by the server, which then corrects the client, and nothing is written outside the disk folder.….File watcher reloads
This branch first had a commit, "Don't let file watcher reloads discard unflushed script changes", because a reload during rename testing lost the renamed file. #78 now fixes the underlying problem more generally: reloads only apply changes made outside the mod. The merge from #81 therefore drops this branch's separate handling of unflushed changes. Its test,
testDiskReloadKeepsUnflushedChanges, still passes, and I rechecked renaming in-game on the final code (three renames into new folders, all on disk with their content).A fix for a resize data-loss bug I found while working on this (the editor came back empty after a window resize, and the next keystroke overwrote the script) is in #77 instead, since it affects master and should land first.
Dropped from the original plan
.stdout/.stderrlog files: they already open as readable text in the terminal, and I found no actual problem with how they're shown today.Testing
./gradlew buildpasses, including the new unit test../gradlew runGameTestServer: all 22 tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9