Repository navigation
Add a button to open the scripts folder in the scripting terminal - #90
Merged
Merged
Conversation
The External Editing section said that the directories of all disks are in world/integratedscripting/, while they are in world/integratedscripting/scripting-disks/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
Editing scripts in an external editor required finding the disk's folder inside the world save. In singleplayer, and when hosting a LAN world, a button below the script list now opens the folder of the selected disk, creating it if needed, and its tooltip shows the folder's path. It is hidden when playing on another server, as the folder is not on the player's own computer then. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MRyTdV3fSV5Q5NPGep4q9
rubensworks
force-pushed
the
terminal-ux-clean/6-layout-and-files
branch
from
October 18, 2026 18:07
917f9c9 to
bfc3760
Compare
rubensworks
force-pushed
the
terminal-ux-clean/7-open-folder
branch
from
October 18, 2026 18:07
39f398b to
120ad29
Compare
Coverage Report for CI Build 39152701083Coverage at 42.409% (no base build to compare)Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Base automatically changed from
terminal-ux-clean/6-layout-and-files
to
master-1.21-lts
October 19, 2026 17:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #89 (then #88, #87, #86, #85).
world/integratedscripting/, but they are inworld/integratedscripting/scripting-disks/.When the button is shown
Only when this client runs the server itself (
Minecraft.hasSingleplayerServer()), so in singleplayer and when hosting a LAN world. On a dedicated server, or as a LAN guest, the folder is on another computer, so the button is not added and the "+" button keeps its full width. Without a selected disk, the button is disabled.It sits below the script list rather than in the editor toolbar: the English title only fits next to the current toolbar with a 1px margin, and the script list is where the other file action ("+") is. It is therefore not shown in focus mode.
The folder is opened with
Util.getPlatform().openPath, the same call vanilla uses for "Open Resource Pack Folder", so it behaves the same on Windows, macOS and Linux.Validation
In a dev client driven by clientdevbridge:
.../saves/<world>/integratedscripting/scripting-disks/1.xdg-open, so I put a fake one on the client'sPATHthat records its arguments. A click calls it with the selected disk's folder; Minecraft logs an error instead when it's missing, as with the vanilla buttons.hasSingleplayerServer()check above.Testing
./gradlew buildand./gradlew runGameTestServer(23 tests) pass.Generated by Claude Code