Fix 26.3 neoforge server crashes on NeoForge 26.3.0.20-beta+ - #98
Merged
Merged
Conversation
Fixes the crash on NeoForge 26.3.0.20-beta and newer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RR4D2pnFdhtTzJpTf9EhqK
All versions up to 26.3-26.3.0.0.7 still use DataPackRegistryEvent$NewRegistry, which NeoForge 26.3.0.20-beta removed, so the server crashes on startup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RR4D2pnFdhtTzJpTf9EhqK
rubensworks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NeoForge 26.3.0.20-beta removed
DataPackRegistryEvent$NewRegistry, and two mods in the 26.3 neoforge packs still used it, so the server crashed during mod construction. This is whyBuild (server, cyclops-all, 26.3, neoforge)andBuild (server, cyclops-all-deps, 26.3, neoforge)fail on master.everlastingabilities-26.3-neoforgefrom2.5.10-410to2.5.10-413in both packs. That build includes the fix from Fix crash on NeoForge 26.3.0.20-beta and newer EverlastingAbilities#328.cyclops-all-deps): commented out, following the existing convention for deps without a working 26.3 build. Every published version up to26.3-26.3.0.0.7still references the old event, so bumping it (Update dependency com.github.glitchfiend:TerraBlender-neoforge to v26.3-26.3.0.0.7 - autoclosed #92) wouldn't help. It can be re-enabled once upstream publishes a fixed build.🤖 Generated with Claude Code
https://claude.ai/code/session_01RR4D2pnFdhtTzJpTf9EhqK