Repository navigation
fix(attest): upload signed provenance for keyless signing - #134
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With the documented keyless signing configuration (
keyless: true, nosign-key) andreport-artifact: true(the default), the action invokes the CLI with--keylessand--output-signed-prov, but uploads only the unsigned provenance. The signed provenance artifact upload currently requires a nonemptysign-key, so the keyless signature output is missing from the downloadable workflow artifacts.Change
Include keyless signing in the existing signed-artifact upload condition. Key-based signing, unsigned generation, and
report-artifact: falseretain their behavior. Rebuildattest/dist/index.jsand add dependency-free entry-point fixture tests, runnable withcd attest && npm test.This fixes an output-artifact omission; it does not change signing, verification, or acceptance of signatures.
Validation
npm ci --ignore-scripts --no-audit --no-fundand ncc 0.38.4 rebuild: passed. Generated bundle has the matching one-line condition change.git diff --check: passed.Local checks used Node 24.14.1 on Windows; VM Modules emits its experimental warning. Node20, real Cimon/signing services, GitHub artifact uploads, GHES, and multi-OS end-to-end execution were not tested locally. No live monitoring, secrets, or workflow dispatch was used for the fixture tests.