Repository navigation
Conversation
Pass a KMS key URI (HashiCorp Vault transit: vault://<key-name>) to sign the provenance statement with a key held in Vault. The input is forwarded as --kms, include-timestamp and timestamp-server-url are forwarded with it when include-timestamp is true (as with sign-key), and the signed provenance is uploaded as an artifact. Requires cimon v1.0.28 or later. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8181d81b71
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…head The rebuild-dist job checks out the PR head SHA, a detached HEAD, so the bare `git push` in the auto-commit step failed with "You are not currently on a branch". Push to the PR branch by name instead, leased on the PR head SHA the run built from, so the push lands only while the branch is unchanged. The workflow also runs when its own file changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
kmsinput tocimon-action/attestfor signing provenance with a KMS key. HashiCorp Vault transit is the supported backend:kms: vault://<key-name>, with the Vault connection in the job'sVAULT_ADDRandVAULT_TOKENenvironment variables.Changes
attest/action.yml: newkmsinput.include-timestampandtimestamp-server-urldescriptions now cover KMS signing.attest/index.js:kmsas--kms;--include-timestamp=trueand--timestamp-server-urlfor KMS signing wheninclude-timestampis true, the same rule as forsign-key;sign-key.attest/README.md: KMS signing section with the Vault variables, transit mount and key types, how verifiers get the public key, and the new row in the inputs table.attest/dist/index.jsis rebuilt with ncc 0.38.4, matching the workflow's output, and committed.Rebuild attest dist workflow
Folded in from #136. The
rebuild-distjob checks out the PR head SHA, so the working copy is a detached HEAD, and the baregit pushin its auto-commit step failed withfatal: You are not currently on a branch(seen on this PR's first run).git push --force-with-lease="refs/heads/$PR_HEAD_REF:$PR_HEAD_SHA" origin "HEAD:refs/heads/$PR_HEAD_REF". Both values come fromgithub.event.pull_request.headthroughenv:. The push lands only while the branch still points at that SHA; if it moved forward, was reset to an earlier commit, or was deleted during the run, the push is rejected..github/workflows/build-attest-dist.yamlchanges, so edits to it are exercised on their own PR.The step script was extracted from the workflow and run against a local bare remote, checked out at a detached PR head with the bundle rebuilt:
The previous step exits 128 (
You are not currently on a branch) whenever the bundle needs a commit, whatever the branch state. With this change:dist already up to dateOn this PR the bundle is already in sync, so the workflow exits early. The push path runs on the next PR that changes
attest/index.jswithout committing the bundle. A push made withGITHUB_TOKENdoes not start new workflow runs, so the bot commit carries no checks of its own; push another commit or re-run the workflows if checks are needed on it.Compatibility
The
kmsinput requires cimon v1.0.28 or later. The action installs the latest cimon release at runtime, so this should merge once v1.0.28 is published. Workflows that do not setkmsare unaffected. The workflow fix does not depend on the cimon release.🤖 Generated with Claude Code