[v8] fix: do not eagerly read Connection.serverPostConnectionCheck - #8786
Merged
aldbr merged 1 commit intoSep 11, 2026
Merged
Conversation
m2crypto 0.46.0 removed the serverPostConnectionCheck class attribute from SSL.Connection. It was used as the default argument of a getattr() lookup, and Python evaluates that default eagerly, so every server-side handshake raised AttributeError regardless of whether postConnectionCheck was set. Look the fallback up with getattr() too, matching what M2Crypto's own Connection.accept() now does. BEGINRELEASENOTES *Core FIX: server-side DISET handshakes no longer raise AttributeError with m2crypto >=0.46 ENDRELEASENOTES
aldbr
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Independent of the m2crypto version bump. m2crypto 0.46.0 removed the
serverPostConnectionCheckclass attribute fromSSL.Connection; DIRAC used itas the default argument of a
getattr()lookup, and Python evaluates thatdefault eagerly, so every server-side handshake raised
AttributeError. Thecurrent
<0.46pin is the only reason this has not been hit in production.Verified against
Test_SSLTransport.py: 4 passed with m2crypto 0.45.1 (no-op)and 4 passed with 0.50.0, where each M2 test previously hung for
BaseTransport.iReadTimeout(600s) and cancelled the job.Refs DIRACGrid/DIRACOS2#192
BEGINRELEASENOTES
*Core
FIX: server-side DISET handshakes no longer raise AttributeError with m2crypto >=0.46
ENDRELEASENOTES