Modified the pop_limit_pct and pop_size_pct values in moduleconfs.data.xml… - #354
Merged
Merged
Conversation
…a.xml so that latency buffers that use these values are typically mostly full instead of mostly empty.
eflumerf
approved these changes
Oct 2, 2026
Collaborator
Author
|
Here is a file with TRACE messages that demonstrate a latency buffer being shrunk down to 10% of its configured size during the handling of a DataRequest: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…so that latency buffers that use these values are typically mostly full instead of mostly empty.
Description
The current values for
pop_limit_pctandpop_size_pctinmoduleconfs.data.xmlare ridiculous (IMO) and are left over from the v4-v5 conversion.What they specify is that the latency buffer is to be kept between 10% and 50% full. This can adversely affect the running of miniDAQ systems when the LB contents are shrunk down to 10% and relevant data for a pending
DataRequestdisappears. I noticed instances of this problem when running thedfmodules/large_trigger_record_teston np04-srv-019.This PR changes the "pct" values in
moduleconfs.data.xmlso that latency buffers are allowed to be mostly full (e.g. 70%-80%) instead of forcing them to be mostly empty.I can post TRACE messages that demonstrate the problem that I observed with the
large_trigger_record_test.py, if that would be useful.Type of change
Testing checklist
dbt-build --unittest)dunedaq_integtest_bundle.sh)