Skip to content

Linting Fixes - #33

Merged
jcfreeman2 merged 1 commit into
developfrom
eflumerf/Linting
Oct 2, 2026
Merged

jcfreeman2 merged 1 commit into
developfrom
eflumerf/Linting

Conversation

@eflumerf

Copy link
Copy Markdown
Member

Description

This PR fixes issues identified by dbt-build --lint serialization.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@eflumerf
eflumerf requested a review from jcfreeman2 September 29, 2026 14:45
@eflumerf eflumerf self-assigned this Sep 29, 2026

@jcfreeman2 jcfreeman2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed no complaints from the linter; approved.

@jcfreeman2
jcfreeman2 merged commit 94b1d71 into develop Oct 2, 2026
1 check passed
@jcfreeman2
jcfreeman2 deleted the eflumerf/Linting branch October 2, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants