Repository navigation
CI: run backend checks on every PR, pause AWS workflows - #11
Merged
Merged
Conversation
Updated workflow trigger to manual dispatch only.
Updated workflow triggers to only allow manual execution.
zackary-masri
marked this pull request as ready for review
October 25, 2026 09:35
6 tasks done
# Conflicts: # .github/Architecture.md
alessiopagliarulo
approved these changes
Oct 29, 2026
alessiopagliarulo
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Zackary! Verified: frontend and backend checks all pass on the latest commit, and this also fixes the TypeIs import error that broke backend tests on nextjs. Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Why nothing ever ran
The workflow files were fine. GitHub Actions just wasn't turned on for this repo. Someone has since turned it on (Actions made an automatic commit on #10 on Oct 24).
What this PR changes
prod-deploy(that branch still exists). Now manual-only.dlp-terraform/. Now manual-only.push-django-ecs.yml and push-training-ecs.yml were already manual-only, so I left them. Nobody should click "Run workflow" on any of these four until AWS ownership is confirmed.
Frontend checks
These install the newest pnpm, which doesn't match our old lockfile. Dan's #10 fixes this, so frontend should go green once #10 is merged.
Backend test fix
The backend test job crashed before any test ran (
ImportError: cannot import name 'TypeIs'). Setup installs the latest PyTorch, thenpoetry installreplaced typing-extensions with the old 4.8.0 from training/poetry.lock, which is too old for PyTorch. Bumped that one entry to 4.12.2.Frontend fails with ERR_PNPM_BROKEN_LOCKFILE (lockfile v6 vs pnpm that needs v9), which is what #10 fixes.
Note
Low Risk
Changes are limited to GitHub Actions triggers and a dependency lock bump; no runtime application or auth logic is modified.
Overview
Backend CI now runs lint and tests on every pull request by removing the
training/**path filter frombackend.yml, so changes outsidetraining/still get checked.AWS-related automation is paused until account ownership is confirmed (#5):
aws.ymlno longer deploys on pushes toprod-deployand only runs via workflow_dispatch, with the same manual-only trigger applied to terraform-validate.yml (replacing push/PR runs ondlp-terraform/**). Comments in those workflows document the Fall 2026 pause.Backend tests in CI should stop failing on
ImportError: cannot import name 'TypeIs'aftertyping-extensionsis bumped from 4.8.0 to 4.12.2 intraining/poetry.lock, so Poetry no longer downgrades typing support below what current PyTorch expects.Reviewed by Cursor Bugbot for commit a3a4270. Bugbot is set up for automated code reviews on this repo. Configure here.