Skip to content

refactor: remove OpenVPN singleton and own instance in GUIOptionOpenVPN #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
funa-tk merged 1 commit into from
Oct 22, 2026
Merged

refactor: remove OpenVPN singleton and own instance in GUIOptionOpenVPN #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/main/java/core/packetproxy/OpenVPN.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,11 @@

public class OpenVPN {

private static OpenVPN instance = null;
private static final String imageName = "alekslitvinenk/openvpn";
private static final String containerName = "packetproxy_ovpn";
private static final String volumeName = "packetproxy_ovpn_volume";
private boolean pulling = false;

public static OpenVPN getInstance() throws Exception {
if (instance == null) {

instance = new OpenVPN();
}
return instance;
}

private DockerClient getClient() {
DockerClientConfig config = DefaultDockerClientConfig.createDefaultConfigBuilder().build();
DockerHttpClient httpClient = new ApacheDockerHttpClient.Builder().dockerHost(config.getDockerHost())
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/core/packetproxy/gui/GUIOptionOpenVPN.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public class GUIOptionOpenVPN extends GUIOptionComponentBase<OpenVPNForwardPort>

public GUIOptionOpenVPN(JFrame owner) throws Exception {
super(owner);
this.openVPN = OpenVPN.getInstance();
this.openVPN = new OpenVPN();
this.openVPNForwardPorts = OpenVPNForwardPorts.getInstance();
this.openVPNForwardPorts.addPropertyChangeListener(this);
this.table_ext_list = new ArrayList<OpenVPNForwardPort>();
Expand Down
Loading