Repository navigation
chore: resolve pnpm allowBuilds placeholders - #224
Merged
Merged
Conversation
pnpm 11 wrote "set this to true or false" placeholders into pnpm-workspace.yaml and they were committed in #207. pnpm 11 rejects them (ERR_PNPM_IGNORED_BUILDS), so `pnpm install` / `pnpm exec` fail locally. Set all four to false, matching what pnpm 10 (CI) has always done. None of the scripts are needed: msw's postinstall only copies the worker into a configured `msw.workerDirectory` (none set), sharp ships prebuilt @img binaries, and esbuild/workerd resolve their prebuilt platform packages.
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#207 accidentally committed pnpm 11's auto-generated
allowBuildsplaceholders (esbuild: set this to true or false, …). pnpm 11 treats them as unresolved and fails withERR_PNPM_IGNORED_BUILDS, so anyone on a current pnpm can'tpnpm installorpnpm exec(this brokepnpm exec bumppduring the v0.2.11 release). CI is unaffected because it pins pnpm 10.7.1.This sets all four to
false, which is what pnpm 10 has always done here (builds skipped by default):mswmockServiceWorker.jsintomsw.workerDirectory, which no package configuressharp@img/sharp-*binary existsesbuild@esbuild/<platform>package is used either wayworkerd@cloudflare/workerd-<platform>Testing
Fresh
pnpm install --frozen-lockfilein clean worktrees:ERR_PNPM_IGNORED_BUILDS), and the yaml isn't rewrittenWith no build scripts run (pnpm 11 install):
packages/sdk:build,test:package,lint,format:check,typecheck,testall passexamples/react-vite:vite buildpasses (esbuild)examples/hono-edge:wrangler --versionworks and resolves the prebuilt workerd binaryNote
Low Risk
Workspace-only pnpm config change; no application or runtime logic is modified.
Overview
Replaces pnpm 11’s auto-generated
allowBuildsplaceholder strings inpnpm-workspace.yamlwith explicitfalseforesbuild,msw,sharp, andworkerd.That matches pnpm 10’s default (skip those install/postinstall scripts) and unblocks
pnpm install/pnpm execon pnpm 11, which otherwise fails withERR_PNPM_IGNORED_BUILDSwhen the placeholders are left unresolved.Reviewed by Cursor Bugbot for commit eaf44cc. Bugbot is set up for automated code reviews on this repo. Configure here.