"Clear all" label; live readout while dragging a pin set - #346
Merged
Merged
Conversation
…re changes - #343: the tables footer button now reads "Clear all" - #344: commitAnnotationChange re-reads the readout column, so a dragged harmonic set shows its live spacing (and a sideband set its live fundamental) instead of the value at the press Closes #343 Closes #344 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BGtiB9vw836PyrqzYTbQqw
Contributor
PR PreviewPreview deployment is ready! View Preview Last updated: 2026-10-02T11:21:44.871Z |
Per review on #344: the number an analyst measures, and the one a member drag changes, is the spacing for both pin-set families. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BGtiB9vw836PyrqzYTbQqw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commitAnnotationChangenow callsrefreshReadoutTarget, so the readout column re-reads the selected feature on every annotation change, not just when the selection changes. Dragging a pin set now updates the large readout live. Arrow-key nudges and marker drags pick up the same fix.describeSelectioninsrc/core/selectionTarget.js).Tests
tests/harmonics-mode.spec.jsandtests/sideband-mode.spec.jscheck the readout against the live spacing mid-drag. The harmonics case fails without the fix.yarn typecheck,yarn lint,yarn hygiene,yarn test:unitand the fullyarn test(537 passed) are all clean.Closes #343
Closes #344
🤖 Generated with Claude Code
https://claude.ai/code/session_01BGtiB9vw836PyrqzYTbQqw