ElementTag Updates - #119
Open
MC-Samuel wants to merge 3 commits into
Open
Conversation
tal5
requested changes
Nov 30, 2025
| return new ElementTag(""); | ||
| } | ||
| return new ElementTag(Character.toUpperCase(object.element.charAt(0)) + object.element.substring(1).toLowerCase()); | ||
| return new ElementTag(object.element.isEmpty() ? "" : Character.toUpperCase(object.element.charAt(0)) + object.element.substring(1).toLowerCase()); |
Member
There was a problem hiding this comment.
Not sure if I see the benefit in these sorts of changes? For simpler lines sure but this is already pretty cluttered to look at - there's nothing wrong with separating an early return (and also more consistent with the rest of the tags here).
| return null; | ||
| } | ||
| String regex = attribute.getParam(); | ||
| String regex = param.toString(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@exampleformat.isEmpty()