Abstract data actions - #124
Open
davight wants to merge 11 commits into
Open
Conversation
davight
marked this pull request as ready for review
May 30, 2026 11:49
Member
|
Please run before/after tests on common cases and edge cases for basic numeric element handling. How is invalid data (eg add/mul/div/whatever on a flag but the flag's value is not a number) handled? How is initial value handled ( |
mcmonkey4eva
reviewed
Sep 5, 2026
| if (index != 0) { | ||
| if (index == Integer.MAX_VALUE && !list.isEmpty()) { | ||
| list.remove(list.size() - 1); | ||
| list.removeLast(); |
Member
There was a problem hiding this comment.
I think this is a jdk version break
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull-Request adds support for ObjectTag to define its own data actions.
(Keeping this as draft for now to hear your opinions on the design and everything)
Related discussion thread: https://discord.com/channels/315163488085475337/1468638851802075270
Additions:
Actionable<T extends ObjectTag>that provides 4 methodsxOperation(ObjectTag value, TagContext context), wherexissubstraction,multiplication,division,addition. With default implementation of throwing exception that the given object does not support given operation.DurationTag:+:DurationTag,DurationTag:-:DurationTag)TimeTag:+:DurationTag,TimeTag:-:DurationTag)VectorTag:+:VectorTag,VectorTag:-:VectorTag,VectorTag:*:ElementTag,VectorTag:/:ElementTag)firstjust like we have for last usinglastChanges:
ElementTag.class(for the new Actionable system)DataAction.classDataActionHelper.class