-
-
Notifications
You must be signed in to change notification settings - Fork 38
Add ms suffix support to DurationTag #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
19ad20c
664acd2
609ffc1
8749207
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,9 @@ public class RepeatingSchedulable extends Schedulable { | |
|
|
||
| public RepeatingSchedulable(Runnable runnable, float fireRate) { | ||
| run = runnable; | ||
| if (fireRate > 0 && fireRate < 0.05f) { | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this is very questionable and probably wrong
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i'll work on this; i expected if somebody asks |
||
| fireRate = 0.05f; | ||
| } | ||
| fireEverySeconds = fireRate; | ||
| secondsLeft = fireRate; | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this... does anything of value with BigDecimal?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before this commit, two of my close-edge tags parsed as
1.000000000001msor something crazy; I've lost the log since