Repository navigation
Conversation
Package the GUI with a from-source redumper so a sandboxed desktop install can dump discs and land on Flathub later. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The setup instructions fail when the Flathub remote is not already configured.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds Flatpak packaging for Linux, including desktop integration, metadata, vendored dependencies, and CI validation.
Changes:
- Builds bundled redumper b750 and the Rust GUI.
- Adds Flatpak permissions and desktop metadata.
- Adds build instructions and an x64 CI job.
| File | Description |
|---|---|
.github/workflows/build.yml |
Builds and verifies the Flatpak. |
README.md |
Documents Flatpak installation. |
packaging/flatpak/cargo-sources.json |
Vendors locked Cargo dependencies. |
packaging/flatpak/com.redumper.gui.desktop |
Adds desktop launcher metadata. |
packaging/flatpak/com.redumper.gui.metainfo.xml |
Adds AppStream metadata. |
packaging/flatpak/com.redumper.gui.yml |
Defines the Flatpak build and permissions. |
src/main.rs |
Sets the window application ID. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
A fresh Flatpak install has no flathub remote, so the documented runtime install failed before it could start. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/app/bin.--device=allis required because dumping needs/dev/sg*and/dev/sr*and there is no portal for that.com.redumper.guiand add a desktop file, AppStream metainfo, and an x64flatpak-builderCI job.MPF.Checkbinary is not visible inside the sandbox.This is independent of the AppImage pull request. It is one of two packaging options for #9. Submitting the same manifest to Flathub should wait until a release tag contains these files, then replace the
type: dirGUI source with that git commit.Test plan
flatpak-buildercompletes on x64 against SDK 25.08 and installsredumperandredumper-guinext to each otherMade with Cursor