Skip to content

Adopt central PowerShell lint workflow - #5

Merged
DevOpsDerek merged 5 commits into
mainfrom
devopsderek-adopt-central-powershell-lint
Oct 4, 2026
Merged

DevOpsDerek merged 5 commits into
mainfrom
devopsderek-adopt-central-powershell-lint

Conversation

@DevOpsDerek

@DevOpsDerek DevOpsDerek commented Oct 4, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Replace duplicated PSScriptAnalyzer CI with central workflow .github/workflows/lint-powershell.yml, pinned to current central main commit 30f86d7d8536364b0a31de4bc66214b39e8785bb.
  • Pin PSScriptAnalyzer 1.24.0 and pass repository-owned PSScriptAnalyzerSettings.psd1.
  • Preserve the separate Pester job and NUnit XML artifact; local lint fails on Error and Warning diagnostics.

Validation

  • Workflow YAML parses and git diff --check passes.
  • Hosted CI passed with the previous central workflow SHA; rerunning all checks against current central main SHA. Local PowerShell is unavailable.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings October 4, 2026 20:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved blocking issues were identified.

Review effort: Lite
Findings: None

What changed in this PR

Adopts a pinned central PowerShell lint workflow while aligning local linting and documentation.

Changes:

  • Uses PSScriptAnalyzer 1.24.0 with repository settings.
  • Fails local linting on Error and Warning diagnostics.
  • Preserves the separate Pester job and artifact.
File Summary
README.md Documents updated lint behavior.
lint.ps1 Fails on Error and Warning diagnostics.
.github/​workflows/​ci.yml Uses the central reusable lint workflow.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings October 4, 2026 20:31
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Align local lint scope with CI and update the workflow reference to the merged commit.

Review effort: Lite
Findings: None

Copilot AI lite review requested due to automatic review settings October 4, 2026 20:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Update the central workflow pin after the published fix and confirm green hosted CI.

Review effort: Lite
Findings: 1 High severity

Open (1)

Comment thread .github/workflows/ci.yml Outdated
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings October 4, 2026 20:37
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The central workflow must disable credential persistence before approval.

Review effort: Lite
Findings: 1 High severity

Open (1)
Resolved since last review (1)

Comment thread .github/workflows/ci.yml Outdated
else {
Write-Output "PSScriptAnalyzer: no issues found."
}
uses: DevOpsDerek/workflows/.github/workflows/lint-powershell.yml@5ecebff22598835cbf5ccd7bfa07c036cce22ee9
Copilot AI lite review requested due to automatic review settings October 4, 2026 20:40
@DevOpsDerek
DevOpsDerek merged commit 54bbc2d into main Oct 4, 2026
5 checks passed
@DevOpsDerek
DevOpsDerek deleted the devopsderek-adopt-central-powershell-lint branch October 4, 2026 20:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues remain.

Review effort: Lite
Findings: 1 High severity

Open (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants