Cameraz - #995
Open
AnastaZIuk wants to merge 192 commits into
Open
Cameraz#995AnastaZIuk wants to merge 192 commits into
AnastaZIuk wants to merge 192 commits into
Conversation
…s - we were never be able to do ourMatrixT = glmMatrixT and its important since a lot of utils create glmMatrixT actually
…atrix xD remove the = operator glm -> to ours
…H (ambiguity dependent type issues), reference #760
…ng/Nabla/pull/760/files#r1816728485 for #760 PR, update examples_tests submodule
… were missing an equivalent of E_KEY_CODE. Update examples_tests submodule
Erfan-Ahmadi
reviewed
Sep 8, 2026
Erfan-Ahmadi
reviewed
Sep 8, 2026
Erfan-Ahmadi
reviewed
Sep 8, 2026
Comment on lines
+272
to
+273
| const TRS operator()() const | ||
| { |
Contributor
There was a problem hiding this comment.
- this function is unused and is a bit funny, cause it's the same function but when you pass
hlsl::matrix<T, 4u, 4u>it treats as row-major but otherwise column major and the function is never used btw.
Contributor
|
the convention in your camera ext is super unclear:
|
Erfan-Ahmadi
reviewed
Sep 8, 2026
Erfan-Ahmadi
reviewed
Sep 9, 2026
Erfan-Ahmadi
reviewed
Sep 9, 2026
Erfan-Ahmadi
reviewed
Sep 9, 2026
| } | ||
|
|
||
| template<typename VecA, typename VecB, typename T> | ||
| static inline bool nearlyEqualVec3(const VecA& a, const VecB& b, const T epsilon) |
Contributor
There was a problem hiding this comment.
we have nbl::hlsl::RelativeApproxCompareHelper that should even work for matrices. this is redundant
Erfan-Ahmadi
reviewed
Sep 9, 2026
Contributor
|
not included in this PR but needs to be fixed: compare with 0.0 or any other subnormal even with a generous tolerance with return false. that's causing some quaternion stuff to be nan when they shouldn't e.g here: |
# Conflicts: # examples_tests
…undant math util functions, consistent matrix conventions (mat4x4 vs new CameraBasis).
…and replace with RigPose, seperate mat4x4 from manipulate calls into a `setPose` function. a bit more documentations. remove passthrough functions that add to confusion and bloat the codebase.
… follow utils. move stuff to cpp
…pplied it to another camera, plus everything built on it (presets, keyframe tracks, playback, persistence, follow, sequence scripts, the scripted runtime and its checks), now lives in `examples_tests/61_UI/include/camera/`
…on between projection and cameraWithProjection)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the new camera stack as Nabla::ext::Cameras.