Skip to content

docs: Update contribution guidelines - #1767

Open
ZohebShaikh wants to merge 1 commit into
mainfrom
ZohebShaikh/contribution_guidelines
Open

ZohebShaikh wants to merge 1 commit into
mainfrom
ZohebShaikh/contribution_guidelines

Conversation

@ZohebShaikh

Copy link
Copy Markdown
Contributor

I have added the feedback given from the away day and Douglas's presentation to update the contribution guidelines

Before merging

Create the labels

R=DiamondLightSource/blueapi
# Rename existing labels so issues that already use them keep their status
gh label edit "help wanted"         -R $R --name help-wanted
gh label edit wontfix               -R $R --name wont-do
gh label edit "needs clarification" -R $R --name needs-info       -d "Waiting on the reporter"
gh label edit deferred              -R $R --name backlog          -d "Valid, not planned for now"
gh label edit "decision pending"    -R $R --name under-discussion -d "Solution still being worked out"
# New labels
gh label create needs-triage      -R $R -c ededed -d "New, not yet triaged"
gh label create ready             -R $R -c 0e8a16 -d "Agreed and scoped, can be picked up"
gh label create awaiting-response -R $R -c fbca04 -d "No core team response yet"
gh label create stale             -R $R -c cfd3d7 -d "No activity, will be closed"
for p in critical:b60205 high:d93f0b medium:fbca04 low:c2e0c6; do
  gh label create "support: ${p%:*}" -R $R -c ${p#*:} -d "Support team priority"
done

Enable private vulnerability reporting (repo admin)
- Settings → Advanced Security (or "Code security") → Private vulnerability reporting → Enable
- or: gh api -X PUT repos/DiamondLightSource/blueapi/private-vulnerability-reporting
- Check: https://github.com/DiamondLightSource/blueapi/security/advisories/new opens the report form

Set start-date in .github/workflows/triage.yml to the merge date.

After merging

Enable round-robin review assignment (team maintainer)
- https://github.com/orgs/DiamondLightSource/teams/developers-daq-core → Settings → Code review
- Enable auto assignment, 1 reviewer, routing algorithm "Round robin", untick "notify the entire team"

Check the reminder: start the Triage workflow by hand (Actions → Triage → Run workflow) and check the team mention actually sends a notification.

@ZohebShaikh
ZohebShaikh requested a review from a team as a code owner November 16, 2026 12:46
@codecov

codecov Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.31%. Comparing base (4701980) to head (2945fd5).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1767   +/-   ##
=======================================
  Coverage   96.31%   96.31%           
=======================================
  Files          50       50           
  Lines        3831     3831           
=======================================
  Hits         3690     3690           
  Misses        141      141           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZohebShaikh
ZohebShaikh force-pushed the ZohebShaikh/contribution_guidelines branch from 3335725 to 2945fd5 Compare November 16, 2026 12:51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant