Add API endpoints to transfer OTF directory and include OTF files in workflow message - #877
Merged
Conversation
…d to trigger the request
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #877 +/- ##
==========================================
+ Coverage 54.72% 54.83% +0.10%
==========================================
Files 101 101
Lines 11337 11417 +80
Branches 1507 1520 +13
==========================================
+ Hits 6204 6260 +56
- Misses 4806 4821 +15
- Partials 327 336 +9 🚀 New features to boost your workflow:
|
tieneupin
marked this pull request as ready for review
September 3, 2026 09:00
d-j-hatton
reviewed
Sep 3, 2026
d-j-hatton
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #876. We now set up API endpoints on the instrument and backend servers to facilitate the transfer of a chosen OTF directory from the source to the destination, and to include the OTF files discovered in the processing request to
cryoem-services.The backend server will verify that the desired destination visit exists, construct the path fragment needed for the instrument server to construct the rsync command, and send along all relevant information to the instrument server.
On the instrument server end, it will construct the rsync command needed to transfer the chosen directory to the destination location, run the rsync command in a subprocess, then return a message with the expected path to the OTF directory on the server side.
The backend server, upon receiving a success message, will forward along the expected OTF directory path to the website that requested it.
With the OTF directories now registered in the database, the cryo-SIM reconstruction API endpoint has also been updated to use the registered OTF directory to look for OTF files, and include them in the processing request to
cryoem-service.Actual diff is +212/-0, with the rest of the diff being due to the addition of new tests.
NOTE: This PR is tied to DiamondLightSource/murfey-frontend#81, and will have to be deployed alongside the version that contains it.