chore: align dev Node requirement with Vitest 5 - #18
Merged
Conversation
Vitest 5 (#16) requires Node ^22.12.0 || ^24 || >=26 and declares a peer of @types/node ^22 || >=24, but the repo still said Node 20: - `@types/node` ^20.19.35 -> ^22.19.0 (resolves 22.20.2). Every install printed an unmet-peer warning; it is gone. - `.nvmrc` pins 22.12.0, the real floor rather than a bare `22`, which would let 22.0-22.11 through and fail the suite unexplained. - CLAUDE.md states the requirement next to the dev commands. Toolchain only: the package declares no `engines` field and its peer ranges are unchanged, so consumers of the published library see no difference. CI already runs Node 22 (latest 22.x, past 22.12). Verified: no peer warnings on install; typecheck, build and all 33 tests pass; `pnpm audit` clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16 and #17. Vitest 5 requires Node
^22.12.0 || ^24 || >=26and declares a peer of@types/node@^22 || >=24, but the repo still said Node 20.Changes
@types/node^20.19.35→^22.19.0(resolves 22.20.2). Everypnpm installprintedunmet peer @types/node@"^22.0.0 || >=24.0.0". The warning is gone..nvmrc→22.12.0, the real floor. A bare22would accept 22.0–22.11, which fail the suite with no clear cause. (Codex caught exactly that on the equivalent sumit-mcp change.)Consumer impact: none
Toolchain only. The package declares no
enginesfield, and its peer ranges (react >=18,sumit-api >=0.2.0) are unchanged. CI already runsnode-version: 22, which resolves to the latest 22.x, well past 22.12.Verification
pnpm install: no peer warningspnpm typecheck,pnpm build: cleanpnpm test: 33 passedpnpm audit: no known vulnerabilities🤖 Generated with Claude Code