Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
f682c5a to
613583b
Compare
mdroidian
left a comment
There was a problem hiding this comment.
Could you please add a loom video testing other consumers of pageToMarkdown to make sure that this change does not add regressions, eg: Markdown export, PDF Export, Publishing/Importing Roam to Roam.
|
Makes sense. Will work on that tomorrow. Is that an exhaustive list? |
|
I don't believe so |
613583b to
dcd71b7
Compare
https://entire.io/gh/DiscourseGraphs/discourse-graph/trails/27
Verification
Unit tests.
Loom shows both the failure and correction.
Loom video
These Looms cover every runtime consumer of toMarkdown and pageToMarkdown. There are three: publishing the full variant (which the Roam and Obsidian imports read), the Markdown export, and the JSON-LD export. The PDF export also calls toMarkdown, but in a mode this change skips. Every export entry point (command palette, query results, discourse context export, share dialog) goes through the same export callbacks.
Core case: publish, then import through the database. Shows both the failure and the fix.
https://www.loom.com/share/df5bf844af784dfe8986596d1cb39027
(first loom, as is.)
Discourse Graphs Markdown export, imported back with Roam's own Markdown import. Roam's import doesn't handle the YAML frontmatter the export adds, which is unrelated to this change. There is no file-based Discourse Graphs import to test instead: the "Import Discourse Graph" dialog (ImportDialog.tsx) is not opened from anywhere, and it only reads the JSON export, which does not call toMarkdown.
https://www.loom.com/share/c9b58b3329db402b841aa7617d475471
JSON-LD export: node content now uses CommonMark list indentation. Its only consumer today is Matt's AI tooling, which should handle CommonMark.
https://www.loom.com/share/31bb53bdc4214da2bc9d5ff297132584
PDF export: fails with a connection error, on main as well, so fixing it is out of scope here. It renders in document view with flatten, which this change leaves alone. The unit tests "leaves continuation lines alone when flattening" and "…in the document view type" cover that.
https://www.loom.com/share/3307b5d977614cdfbef373d7d4819e5b
Scope check
$scope-checkagainst the ENG ticket and final diff.Done When: NoneStandards check
$dg-pr-adherence-checkagainst the final diff and PR metadata.Nit: I renamed the linear task to be more terse after the branch got its name.
Local delegated full review
$dg-delegated-full-reviewwhen no other full-review workflow is available.What passed
https://linear.app/discourse-graphs/issue/ENG-2326/indent-every-line-of-a-multi-line-roam-block-in-roams-markdown-output