Repository navigation
fix: portable ggml on x86_64 release legs (GGML_NATIVE=OFF) - #5
Merged
Merged
Conversation
whisper.cpp's CMake defaults to GGML_NATIVE=ON, so ext-whisper's vendored ggml was compiled with -march=native for the release runner. The ubuntu-26.04 runners have AVX-512: ext-whisper v0.1.1's x86_64 binary contains 4,460 zmm instructions (v0.1.0: none) and dies with SIGILL on a Ryzen 5 3400G (AVX2, no AVX-512). whisper-rs-sys forwards GGML_* env vars to CMake; OFF selects ggml's portable AVX/AVX2/FMA defaults. x86_64 legs only; arm64 macOS native is the M1 floor. llama-cpp-sys-2 already forces OFF (ext-infer 0.2.1's binary: 0 zmm, runs on AVX2).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ext-whisper v0.1.1's x86_64 release binaries were built with
-march=nativeon AVX-512 runners and crash with SIGILL on AVX2-only CPUs (verified on a Ryzen 5 3400G; v0.1.0 had 0 AVX-512 instructions, v0.1.1 has 4,460). whisper-rs-sys passesGGML_*env vars to CMake, so the managed release workflow now exportsGGML_NATIVE=OFFon x86_64 legs: ggml's portable AVX2 baseline, matching the platform's x86-64-v3 floor. v0.1.1 was never published; ext-whisper v0.1.2 ships the fix. Ships as ext-template v0.2.1.