Repository navigation
feat: CI-enforced stubs check - #6
Merged
Merged
Conversation
Managed .github/scripts/stubs-check.php + a CI step on every test leg + make stubs-check. Listing covers class finality, parents, interfaces, constants, and every method's modifiers, parameters, defaults and return type; run in two processes since both sides declare the same names. Skips with a warning while an extension has no stubs file yet. Release v0.2.2 also records the Dependabot action bumps (#4).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Curated stubs had drifted from the registered classes (
finalon non-final classes,array $options = []vs runtime?array $options = null, missing constructors). This adds a managed check that diffs a Reflection listing of the built extension against one of the stub file, on every CI leg, plusmake stubs-check. Verified locally: it fails on the current ext-whisper/turbovec/infer stubs and passes once they're fixed (PRs follow); skips with a warning on a fresh render with no stubs. Ships as v0.2.2 (also records the #4 action bumps).