Repository navigation
Conversation
Since the KMS RPC certificate must carry a verified attestation, get-keys verifies it, but with a production verifier that ignores the guest's sys-config. On a host that configures its own PCCS, or in a guest whose TEE simulator published trust anchors, get-keys then rejected the KMS that the guest's own setup had just accepted. Build the verifier from the sys-config collateral URLs and the published trust anchors, falling back to the production defaults outside a CVM. Signed-off-by: Kevin Wang <wy721@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dstack-util get-keysverified the KMS withAttestationVerifier::new_prod(None), while system setup verifies the same KMS with the collateral service from the guest's sys-config and any trust anchors the guest published. Since the KMS RPC certificate must carry a verified attestation,get-keysrejected a KMS that setup had just accepted on any host that configures its own PCCS, and in development guests.Build the verifier the way setup does, falling back to the production defaults outside a CVM.
Found by
tc-gos-setup-024(#841) on tdxlab: before the change,get-keysfailed fetching TCB info for the KMS's mock quote from the default PCCS; with it, the KMS attestation verifies against the published anchors.