95 watervapor lsm util func - #96
Merged
Merged
Conversation
rogerkuou
marked this pull request as ready for review
September 10, 2026 12:56
Collaborator
Author
|
Hi @SarahAlidoost , in this PR I implemented the function to make land-sea mask for watervapor data from SST. I made this PR to a feature branch to improve #74 . Maybe you want to review this one first? |
Merged
SarahAlidoost
requested changes
Sep 10, 2026
SarahAlidoost
left a comment
SarahAlidoost
left a comment
Member
There was a problem hiding this comment.
@rogerkuou Please see my suggestions! let me know if something is not clear.
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
Collaborator
Author
|
Thanks @SarahAlidoost , I applied your comments and updated the function names and variable names. Can you give it another look? |
SarahAlidoost
approved these changes
Sep 11, 2026
SarahAlidoost
left a comment
SarahAlidoost
left a comment
Member
There was a problem hiding this comment.
@rogerkuou thanks for addressing the comments. It can be merged.
rogerkuou
added a commit
that referenced
this pull request
Sep 15, 2026
* rename daily notebooks * add draft example notebook for watervapor * check empty dataset in prediction * update hourly watervapor notebook * initiate loss as zero tensor * update notebook * changed loss to float * rename patch with crop in dataset and predict module * fix geo_embeding in the model * remove spatial transfomer from the model * add some model improvemnets * uncomment groupnorm in decoder * improve docstring * remove patch from dataset, adjust api in source modules * fix linters * fix tests * fix docstring and comments * fix nbs * add model.train in train loop (a bug) * update scripts * fix run_best_tuned_model script * rerun example_tuning nb * re-structure training * rename_notebook * add example notebook for daily watervapor data * update unit name * init hourly watervapo notebook * initial water vapor hourly training * add commented out code section for generating 0.5 deg lsm * 95 watervapor lsm util func (#96) * implement lsm convertion func from sst to wv * add unit test; fix linting issue * update notebooks with lsm conversion func * linting * rerun daily notebook * Apply batched suggestions from code review Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com> * rename function * update variable name --------- Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com> * Apply suggestion from @SarahAlidoost Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com> * solve conficts * change spatial_patch_size to spatial_crop_size * remove duplicated cell * remove unuser import * use jan for hourly notebook * update parameters in hourly notebook * rerun hourly notenook --------- Co-authored-by: SarahAlidoost <f.alidoost@esciencecenter.nl> Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #95
this improved PR #74
Add a utility function to make watervapor LSM from SST LSM