Skip to content

temporary fix intake-esgf online tests: remove/xfail CanESM5 that now returns incompatible STAC indices - #3223

Closed
valeriupredoi wants to merge 3 commits into
mainfrom
fix_tests
Closed

valeriupredoi wants to merge 3 commits into
mainfrom
fix_tests

Conversation

@valeriupredoi

@valeriupredoi valeriupredoi commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Description

Closes #3222


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.47%. Comparing base (2f24941) to head (5f024a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3223      +/-   ##
==========================================
- Coverage   96.48%   96.47%   -0.01%     
==========================================
  Files         282      282              
  Lines       16418    16418              
==========================================
- Hits        15841    15840       -1     
- Misses        577      578       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@valeriupredoi

Copy link
Copy Markdown
Contributor Author

@bouweandela this is how I propose we fix the testing issue for now - BTW mypy is a real PITA, sometimes - not often, but sometimes - one really needs commented out code!

@valeriupredoi valeriupredoi mentioned this pull request Sep 23, 2026
@valeriupredoi valeriupredoi changed the title temporary fix intake-esgf onlin tests: remove/xfail CanESM5 that now returns incompatible STAC indices temporary fix intake-esgf online tests: remove/xfail CanESM5 that now returns incompatible STAC indices Sep 23, 2026
@valeriupredoi

Copy link
Copy Markdown
Contributor Author

superseded by using the upcoming release of intake-esgf, and fixes put in by @bouweandela in #3225

@valeriupredoi
valeriupredoi deleted the fix_tests branch September 24, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail

1 participant