Subselection update - #780
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In my attempt to update and simplify the data fetching process. I noticed that the logic still always grabs data as chunks. Now will the sliders can properly slice off the ends of the array. The start of the array was always starting at the beginning of the chunk.
This update should fix that. It also makes it so that if you are subselecting a cached chunk, it updates the offset properly and so you can re-use the cached chunk and see the subselection. Beforehand you would just see who whole cached chunk.
We are still not entirely perfect as it still downloads the entire chunk. But this is getting us closer.