Skip to content

Say that a git-derived version stamp is lost unless stamped #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anakanemison wants to merge 1 commit into from
Open

Say that a git-derived version stamp is lost unless stamped #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,11 @@ rather than recalled). Put `common --check_direct_dependencies=error` in the
generated `.bazelrc` so a declared version that MVS overrides fails the build
instead of being a warning nobody reads.

**Values read from the repository** (`git describe`, a commit hash) are lost
silently: a genrule cannot see `.git` from the sandbox, and the binary reports
an "unknown version". Feed them through `--workspace_status_command` to a
`stamp = 1` rule.

The reference guide covers what is specific to translating its build system
(for CMake: the build type and configure-time generated files).

Expand Down
Loading