fix(marketplace): prevent corrupt registry data loss - #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Marketplace registry reads now fail loudly when
marketplaces.jsonis corrupt or unreadable, so later mutations cannot persist an empty fallback over existing registrations. Registry saves stage complete JSON in a unique same-directory file, restore the existing file mode, and atomically rename it into place; failed replacements clean up the staged file and leave the live registry unchanged.Only
ENOENTrepresents an absent registry. This change does not add backups or cross-process locking; concurrent writers retain last-writer-wins semantics, but readers can no longer observe an in-place truncation.Closes #465
Verification
Automated checks:
Focused result: 30 tests passed. Full result: 1,491 passed, 5 skipped, 0 failed across 137 files.
Built-CLI E2E:
The first add succeeded and left no temporary registry file. After truncation, both
listand the secondaddexited 1 withMarketplace registry ... is unreadableand the refusal-to-overwrite guidance. The final size remained0, proving the corrupt bytes were not replaced.