Repository navigation
Conversation
Share the enabled default with Settings, retain explicit opt-outs, and label the switch Use the new menu. Cover absent and stored preferences, preserving legacy menu inventories and exact chart pixels through isolated opt-out fixtures. Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
BrainLayer ratchetEvery Value below was measured by this run. A row this machine cannot measure says Hosted success gives no verdict on mapped bytes, search p50/p95, idle CPU, hotlane backlog CPU, or fallback replay debt.
🟢 GREEN measured, within budget · 🔴 RED measured, out of budget — a finding to clear before merge · ⚪ n/a not measurable on this machine, never guessed. No RED rows. Measured on Linux/x86_64 · measured |
BrainBar now uses the new menu and brain icon when the preference is unset. Settings › Advanced keeps a “Use the new menu” switch; turning it off restores the previous menu and charts icon. Explicit true/false values are preserved, with no preference migration. The preference reader and Settings toggle share one default.
Proof: fail-first headless Swift coverage of the real controller, menu and icon renderer. Live installed-app behavior is not verified in this lane; the brief forbids screen changes, socket/database access and the three native UI suites.
Tests updated to select the legacy path explicitly rather than assuming an absent key means off:
Added three tests:
testAbsentPreferenceUsesNewMenuAndBrainWithoutWritingAValue,testExplicitFalseUsesPreviousMenuAndExactCharts, andtestExplicitTrueUsesNewMenuAndBrain. These cover the first assigned brain image, new-menu actions, exact legacy menu titles/chart pixels, and preservation of both absent and stored values.Validation:
3fa24d58214a390a5ff8c629b2bf0ecacc667a18: the absent-key test ran and failed 5 assertions (first image, preference, rendered image and menu selection).taskpolicy -b swift test --package-path brain-bar --scratch-path .build.noindex/swift --jobs 4 --filter 'BrainBar(NewMenu|BrainIcon)Tests': 20 passed, 0 failures. Final run started below the load gate at 7.22.python3 -m pytest tests/test_ci_swift_gate.py -q --basetemp=.build.noindex/pytest/w89: 51 passed.git diff --check: passed.BRAINLAYER_PREPUSH_SCOPE=changed-only git push -u origin HEADpassed the repository pre-push gate.The legacy helper uses a private stored suite with automatic domain cleanup. Registering defaults would contaminate the process-wide registration domain; a custom volatile domain was not read by this suite's search path.
Surface check: controller menu selection and first/subsequent icon rendering use the preference reader; Settings uses the shared default. Explicit false retains the old menu inventory and chart pixel checks; explicit true retains the new path. No provider, transport, socket, database, connection-mode or documentation contract changes.
Loop-record: implementer=codex gpt-6.1-sol (T3); reviewer=; rounds=0; defects=0
Review is lead-owned. No reviewer was started and no merge was attempted. Worktree and branch are retained per the lane brief.
🤖 Generated with GPT-6.1 Sol in T3 Code Nightly